-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ "Archive" label in dataset, link to Dataset preview in Wizard #4356
Conversation
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-06 11:22:43 UTC |
…owid-grapher into enhance-archive-dataset-ui
…owid-grapher into enhance-archive-dataset-ui
@rakyi do you know if the CI/CD error is expected, or somehow related to my changes? |
I don't think the failure is either expected or related to your changes. I'm rerunning it manually, let's see if it fails again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart for the one small comment the changes look good to me!
Hmm, the SVG tester failed again. I think it should be safe to merge, but if you really care about it, you can try rebasing on master. |
Minor edits to our Dataset Edit page: