Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ "Archive" label in dataset, link to Dataset preview in Wizard #4356

Merged
merged 13 commits into from
Jan 6, 2025

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Dec 24, 2024

Minor edits to our Dataset Edit page:

  • Add "Archive" label when we are in the edit page of an archived dataset.
  • Hide "Archive" button at the bottom whenever we are in an edit page of an archived dataset.
  • Add a button linking users to the Wizard page "Dataset Preview" for that specific dataset.
  • Nit: Add missing white space to the Variable Edit page.

image

@owidbot
Copy link
Contributor

owidbot commented Dec 24, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-enhance-archive-dataset-ui

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-06 11:22:43 UTC
Execution time: 1.31 seconds

@lucasrodes lucasrodes changed the title disable archiving button if dataset already archived! "Archive" label in dataset, link to Dataset preview in Wizard Jan 3, 2025
@lucasrodes lucasrodes requested a review from danyx23 January 3, 2025 14:40
@lucasrodes lucasrodes changed the title "Archive" label in dataset, link to Dataset preview in Wizard ✨ "Archive" label in dataset, link to Dataset preview in Wizard Jan 3, 2025
@lucasrodes lucasrodes requested review from rakyi and removed request for danyx23 January 3, 2025 14:45
@lucasrodes
Copy link
Member Author

lucasrodes commented Jan 6, 2025

@rakyi do you know if the CI/CD error is expected, or somehow related to my changes?

@rakyi
Copy link
Contributor

rakyi commented Jan 6, 2025

I don't think the failure is either expected or related to your changes. I'm rerunning it manually, let's see if it fails again.

Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart for the one small comment the changes look good to me!

adminSiteClient/DatasetEditPage.tsx Outdated Show resolved Hide resolved
@rakyi
Copy link
Contributor

rakyi commented Jan 6, 2025

Hmm, the SVG tester failed again. I think it should be safe to merge, but if you really care about it, you can try rebasing on master.

@lucasrodes lucasrodes merged commit 9e9dfc9 into master Jan 6, 2025
21 checks passed
@lucasrodes lucasrodes deleted the enhance-archive-dataset-ui branch January 6, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants